Skip to content

fix: GitHub handle validation - allow empty handles and prevent false…#115

Merged
joelamouche merged 2 commits intoTheSoftwareDevGuild:mainfrom
tusharshah21:fex/github-validation
Oct 16, 2025
Merged

fix: GitHub handle validation - allow empty handles and prevent false…#115
joelamouche merged 2 commits intoTheSoftwareDevGuild:mainfrom
tusharshah21:fex/github-validation

Conversation

@tusharshah21
Copy link
Collaborator

  • Allow users to clear their GitHub handle by providing empty string (sets to None)
  • Users can now update their profile with their own existing handle without 'already taken' error
  • Only check for conflicts with handles owned by other users
  • Added comprehensive unit tests for both scenarios (empty_github_handle_allowed, user_can_update_own_github_handle)"

Closes #114

@joelamouche
Copy link
Contributor

Good job! Pls add this commit that I made while testing your changes: 30c1aed
It add the ability to create a profile when no profile is present and the ability to create a profile with a github login from the beginning

@tusharshah21
Copy link
Collaborator Author

Done @joelamouche as you shared, i think those were all the liniting issue

Copy link
Contributor

@joelamouche joelamouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on how to cherry pick a commit

@tusharshah21 tusharshah21 force-pushed the fex/github-validation branch from 8d4683f to 0c1aae3 Compare October 16, 2025 16:05
@tusharshah21
Copy link
Collaborator Author

tusharshah21 commented Oct 16, 2025

Done mate, I hope this is what you were expecting now. First time cherry picking a commit. Learned new thing !!

@joelamouche
Copy link
Contributor

Okay looks good!
Btw to revert your commit you could have done
git reset HEAD~1

and then

git cherry-pick 30c1aed

Anyways, good job on this fix!

Copy link
Contributor

@joelamouche joelamouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG 🚀

@joelamouche joelamouche merged commit 9799104 into TheSoftwareDevGuild:main Oct 16, 2025
4 checks passed
@tusharshah21
Copy link
Collaborator Author

thanks for the recommendation! would keep it in the mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github handle errors

2 participants

Comments